linux-kernel - [PATCH 1/3] scsi: downgrade "write through" error to notice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 08 May 2012 12:20:35 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/3] scsi: downgrade "write through" error to notice

For some reason all USB memory sticks I happen to have trigger an
    Assuming drive cache: write through

error when inserted into a USB port. But if one looks at the code
paths that trigger this error one notices that in most cases either:
- write through is explicitly requested (via the usb-storage
  NO_WP_DETECT flag);
- preceded by a previous error; or
- preceded by an ordinary notice.

So it seems this error can be safely downgraded to a notice.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
 drivers/scsi/sd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5ba5c2a..a887491 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2258,7 +2258,7 @@ bad_sense:
 		sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n");
 
 defaults:
-	sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
+	sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache: write through\n");
 	sdkp->WCE = 0;
 	sdkp->RCD = 0;
 	sdkp->DPOFUA = 0;
-- 
1.7.7.6




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/