linux-kernel - Re: [git pull] irq remapping ops for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 May 2012 05:51:54 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org
Subject: Re: [git pull] irq remapping ops for x86


* Joerg Roedel <joro@...tes.org> wrote:

> (again as a signed email)
> 
> Hi Ingo,
> 
> The following changes since commit d48b97b403d23f6df0b990cee652bdf9a52337a3:
> 
>   Linux 3.4-rc6 (2012-05-06 15:07:32 -0700)
> 
> are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git intr-remapping-ops
> 
> or as a signed tag at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git intr-remapping-ops-for-ingo
> 
> Joerg Roedel (8):
>       iommu: Rename intr_remapping files to intel_intr_remapping
>       iommu/vt-d: Make intr-remapping initialization generic
>       iommu/vt-d: Convert missing apic.c intr-remapping call to remap_ops
>       iommu/vt-d: Convert IR ioapic-setup to use remap_ops
>       iommu/vt-d: Convert IR set_affinity function to remap_ops
>       iommu/vt-d: Convert free_irte into a remap_ops callback
>       iommu/vt-d: Convert MSI remapping setup to remap_ops
>       x86, iommu/vt-d: Clean up interfaces for interrupt remapping
> 
> Suresh Siddha (2):
>       iommu: rename intr_remapping references to irq_remapping
>       iommu: rename intr_remapping.[ch] to irq_remapping.[ch]
> 
>  arch/ia64/include/asm/irq_remapping.h              |    4 +
>  arch/x86/include/asm/irq_remapping.h               |  120 +++++--
>  arch/x86/kernel/apic/apic.c                        |   30 +-
>  arch/x86/kernel/apic/io_apic.c                     |  297 ++++-------------
>  drivers/iommu/Makefile                             |    2 +-
>  drivers/iommu/dmar.c                               |    9 +-
>  drivers/iommu/intel-iommu.c                        |    3 +-
>  .../{intr_remapping.c => intel_irq_remapping.c}    |  355 ++++++++++++++++----
>  drivers/iommu/intr_remapping.h                     |   17 -
>  drivers/iommu/irq_remapping.c                      |  164 +++++++++
>  drivers/iommu/irq_remapping.h                      |   88 +++++
>  include/linux/dmar.h                               |   85 -----
>  12 files changed, 724 insertions(+), 450 deletions(-)
>  create mode 100644 arch/ia64/include/asm/irq_remapping.h
>  rename drivers/iommu/{intr_remapping.c => intel_irq_remapping.c} (66%)
>  delete mode 100644 drivers/iommu/intr_remapping.h
>  create mode 100644 drivers/iommu/irq_remapping.c
>  create mode 100644 drivers/iommu/irq_remapping.h
> 
> This patchset introduces a generic ops-interface for
> accessing interrupt remapping hardware on x86. It factors
> out the VT-d specific code from io_apic.c and moves it to
> drivers/iommu. These changes will be used to add support for
> AMD interrupt remapping hardware.
> 
> Please pull.

I've pulled it, but note that there's an UP build failure:

 drivers/iommu/intel_irq_remapping.c:955:19: error: ‘struct irq_data’ has no member named ‘affinity’

config attached. This has to be fixed before I can push this 
towards linux-next.

Thanks,

	Ingo

View attachment "config" of type "text/plain" (75819 bytes)