linux-kernel - Re: [PATCH 5/5] PA-RISC: fix compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2012 18:34:06 -0400 (EDT)
From:	Mikulas Patocka <mpatocka@...hat.com>
To:	Matt Turner <mattst88@...il.com>
cc:	torvalds@...ux-foundation.org, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Rolf Eike Beer <eike-kernel@...tec.de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>
Subject: Re: [PATCH 5/5] PA-RISC: fix compile errors



On Wed, 9 May 2012, Matt Turner wrote:

> On Wed, May 9, 2012 at 6:19 PM, Mikulas Patocka <mpatocka@...hat.com> wrote:
> > From: Rolf Eike Beer <eike-kernel@...tec.de>
> >
> > This was defined in asm/pdc.h which needs to include asm/page.h for
> > __PAGE_OFFSET. This leads to an include loop so that page.h eventually will
> > include pdc.h again. While this is no problem because of header guards, it is
> > a problem because some symbols may be undefined. Such an error is this:
> >
> > In file included from /home/buildbot/repos/linux/include/linux/bitops.h:35:0,
> >                 from /home/buildbot/repos/linux/include/asm-generic/getorder.h:7,
> >                 from /home/buildbot/repos/linux/arch/parisc/include/asm/page.h:162,
> >                 from /home/buildbot/repos/linux/arch/parisc/include/asm/pdc.h:346,
> >                 from /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:16,
> >                 from /home/buildbot/repos/linux/arch/parisc/include/asm/spinlock.h:6,
> >                 from /home/buildbot/repos/linux/arch/parisc/include/asm/atomic.h:20,
> >                 from /home/buildbot/repos/linux/include/linux/atomic.h:4,
> >                 from /home/buildbot/repos/linux/include/linux/sysfs.h:20,
> >                 from /home/buildbot/repos/linux/include/linux/kobject.h:21,
> >                 from /home/buildbot/repos/linux/include/linux/device.h:17,
> >                 from /home/buildbot/repos/linux/include/linux/eisa.h:5,
> >                 from /home/buildbot/repos/linux/arch/parisc/kernel/pci.c:11:
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h: In function "set_bit":
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:82:2: error: implicit declaration of function "_atomic_spin_lock_irqsave" [-Werror=implicit-function-declaration]
> > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:84:2: error: implicit declaration of function "_atomic_spin_unlock_irqrestore" [-Werror=implicit-function-declaration]
> >
> > Signed-off-by: Rolf Eike Beer <eike-kernel@...xxxxxx>
> 
> Email address got eaten?

I was copying the patch from mailing list web archive and it mangles 
addresses. I fixed the others addresses, but forgot about this one.

Mikulas

> > Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
>