linux-kernel - Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 May 2012 15:39:10 +0530
From:	joseph daniel <josephdanielwalter@...il.com>
To:	balbi@...com
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb/dwc3: Fix the dwc3 dependency

Hi Felipe,

On Fri, May 11, 2012 at 1:27 PM, Felipe Balbi <balbi@...com> wrote:
> On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
>> The warning shown up when ran with randconfig,
>>
>> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
>>
>> Signed-off-by: joseph daniel <josephdanielwalter@...il.com>
>> ---
>>  drivers/usb/dwc3/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index d8f741f..68271fa 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -1,6 +1,6 @@
>>  config USB_DWC3
>>       tristate "DesignWare USB3 DRD Core Support"
>> -     depends on (USB && USB_GADGET)
>> +     depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
>                                              ^^^^
>                                              typo
>
> I would prefer the select to change:
>
> select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)
>
will do this and send out a patch shotly.
> or something similar.
>
>>       select USB_OTG_UTILS
>>       select USB_GADGET_DUALSPEED
>>       select USB_GADGET_SUPERSPEED
>
> --
> balbi

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/