linux-kernel - Re: [PATCH 2/2] mfd: pcf50633-core: Convert to use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 May 2012 07:45:34 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org, Harald Welte <laforge@...monks.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 2/2] mfd: pcf50633-core: Convert to use devm_* APIs

On 05/11/2012 03:31 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Looks good...

> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
[...]
> @@ -237,16 +236,11 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
>  	pcf50633_irq_init(pcf, client->irq);
>  
>  	/* Create sub devices */
> -	pcf50633_client_dev_register(pcf, "pcf50633-input",
> -						&pcf->input_pdev);
> -	pcf50633_client_dev_register(pcf, "pcf50633-rtc",
> -						&pcf->rtc_pdev);
> -	pcf50633_client_dev_register(pcf, "pcf50633-mbc",
> -						&pcf->mbc_pdev);
> -	pcf50633_client_dev_register(pcf, "pcf50633-adc",
> -						&pcf->adc_pdev);
> -	pcf50633_client_dev_register(pcf, "pcf50633-backlight",
> -						&pcf->bl_pdev);
> +	pcf50633_client_dev_register(pcf, "pcf50633-input", &pcf->input_pdev);
> +	pcf50633_client_dev_register(pcf, "pcf50633-rtc", &pcf->rtc_pdev);
> +	pcf50633_client_dev_register(pcf, "pcf50633-mbc", &pcf->mbc_pdev);
> +	pcf50633_client_dev_register(pcf, "pcf50633-adc", &pcf->adc_pdev);
> +	pcf50633_client_dev_register(pcf, "pcf50633-backlight", &pcf->bl_pdev);
>  
>[...]

... but this is really a unrelated change, which isn't even mentioned in the
changelog.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/