linux-kernel - Re: linux-next: Tree for May 10 (fs/inode.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 May 2012 00:49:01 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
CC:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: linux-next: Tree for May 10 (fs/inode.c)

On Thu, 2012-05-10 at 21:36 -0400, Paul Gortmaker wrote:
> On Thu, May 10, 2012 at 5:23 PM, Randy Dunlap <rdunlap@...otime.net> wrote:
> > On 05/10/2012 02:26 AM, Stephen Rothwell wrote:
> >
> >> Hi all,
> >>
> >> Changes since 20120508:
> >
> >
> > when CONFIG_BLOCK is not set:
> >
> > fs/inode.c:1777:6: error: redefinition of 'inode_dio_wait'
> > include/linux/fs.h:2476:20: note: previous definition of 'inode_dio_wait'
> > was here
> 
> Also seen on some arm builds:
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/6291357/
> http://kisskb.ellerman.id.au/kisskb/buildresult/6291378/
> 
> 5eff3957ce8d14c2a254844743dfb84e19e7c2ae is the first bad commit
> commit 5eff3957ce8d14c2a254844743dfb84e19e7c2ae
> Author: Trond Myklebust <Trond.Myklebust@...app.com>
> Date:   Mon May 7 10:44:29 2012 -0400
> 
>     NFS: Ensure that setattr and getattr wait for O_DIRECT write completion
> 
>     Use the same mechanism as the block devices are using, but move the
>     helper functions from fs/direct-io.c into fs/inode.c to remove the
>     dependency on CONFIG_BLOCK.
> 
>     Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
>     Cc: Christoph Hellwig <hch@...radead.org>
>     Cc: Al Viro <viro@...iv.linux.org.uk>
>     Cc: Fred Isaman <iisaman@...app.com>
> 
> :040000 040000 ae33e2ffd172e4d7e2ad6ed219de32de936548cc
> ef2df66b34559dbc0782add108e24a6ef6e4e2ca M      fs
> bisect run success
> 
> P.

Sorry about being so late with this. The changes to include/linux/fs.h
had not been committed in the original branch. Today's linux-next should
have that fixed...

Cheers
  Trond

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com