| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 May 2012 22:46:33 -0300 From: Arnaldo Carvalho de Melo <acme@...stprotocols.net> To: David Ahern <dsahern@...il.com> Cc: Namhyung Kim <namhyung.kim@....com>, linux-kernel@...r.kernel.org, Lucas Meneghel Rodrigues <lmr@...hat.com> Subject: Re: [PATCH] perf-record: Create events initially disabled -- again Em Mon, May 14, 2012 at 07:42:30PM -0600, David Ahern escreveu: > On 5/14/12 7:07 PM, Namhyung Kim wrote: > >>Something else is wrong then. I tested that command (saw your patch in > >>the history) and it worked for me. Also, this code path does not > >>affect perf-stat -- it touches perf-record and perf-test only. > >Ah, right. But still wouldn't it be better changing the conditional > >rather than disabling it unconditionally? > I think it would be best to disable all events initially and then > enable them when ready. It works for perf-record and perf-test just > fine and limits the samples to what you care about. And we need to have all this logic in a central place, the "open" method of perf_evlist :-) The perf_target abstraction is the way to get there, but in the process I think we really need to have each new method with a 'perf test' entry and in addition to that an 'autotest'* entry to test the perf builtins. - Arnaldo * http://autotest.github.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists