linux-kernel - Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 May 2012 00:11:32 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Namjae Jeon <linkinjeon@...il.com>, linux-kernel@...r.kernel.org,
	joe@...ches.com, Amit Sahrawat <amit.sahrawat83@...il.com>
Subject: Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.

Namjae Jeon <linkinjeon@...il.com> writes:

> When application tried to lookup(opendir/readdir/stat) 5000 files in plugging usb device formatted by FAT, If unplugging usb device while lookup files, so many message occured like the below log. and currently it make app slow.
> So this patch use fat_msg_ratelimit function about this message to decrease this messages.
>
> #> ./file_lookup_testcase ./files_directory/
> [   57.768000] usb 2-1.4: USB disconnect, device number 4

[...]

> [   58.040000] FAT-fs (sda1): Directory bread(block 396818) failed
> [   58.048000] FAT-fs (sda1): Directory bread(block 396819) failed
> [   58.052000] FAT-fs (sda1): Directory bread(block 396820) failed
> [   58.060000] FAT-fs (sda1): Directory bread(block 396821) failed

Thanks.

Please handle those patches, Andrew.

> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@...il.com>
> Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
> ---
>  fs/fat/dir.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index aca191b..6eaa28c 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -98,8 +98,8 @@ next:
>  
>  	*bh = sb_bread(sb, phys);
>  	if (*bh == NULL) {
> -		fat_msg(sb, KERN_ERR, "Directory bread(block %llu) failed",
> -		       (llu)phys);
> +		fat_msg_ratelimit(sb, KERN_ERR,
> +			"Directory bread(block %llu) failed", (llu)phys);
>  		/* skip this block */
>  		*pos = (iblock + 1) << sb->s_blocksize_bits;
>  		goto next;

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/