linux-kernel - Re: [vmw_vmci RFC 01/11] Apply VMCI context code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 May 2012 16:47:43 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Andrew Stiegmann (stieg)" <astiegmann@...are.com>
Cc:	linux-kernel@...r.kernel.org, acking@...are.com, dtor@...are.com,
	dsouders@...are.com, cschamp@...are.com, akpm@...ux-foundation.org,
	virtualization@...ts.linux-foundation.org
Subject: Re: [vmw_vmci RFC 01/11] Apply VMCI context code

On Tue, May 15, 2012 at 08:06:58AM -0700, Andrew Stiegmann (stieg) wrote:
> +/*
> + *----------------------------------------------------------------------
> + *
> + * ctx_signal_notify --
> + *
> + *      Sets the notify flag to true.  Assumes that the context lock is
> + *      held.
> + *
> + * Results:
> + *      None.
> + *
> + * Side effects:
> + *      None.
> + *
> + *----------------------------------------------------------------------
> + */
> +
> +static void ctx_signal_notify(struct vmci_ctx *context)
> +{
> +	if (context->notify)
> +		*context->notify = true;
> +}

What's with the bizarre comment block format here and throughout the
code?  Care to fix it up (i.e. delete it all from static functions, and
use kerneldoc for public functions.)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/