linux-kernel - Re: [PATCH 3/4] Staging: ipack/bridges/tpci200: remove TPCI200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 May 2012 17:37:24 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Samuel Iglesias Gonsalvez <siglesias@...lia.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Staging: ipack/bridges/tpci200: remove
 TPCI200_SHORTNAME constant

On Fri, May 18, 2012 at 11:10:07AM +0200, Samuel Iglesias Gonsalvez wrote:
> Removed TPCI200_SHORTNAME. For the pr_* the name of the module is already
> included due to pr_fmt declaration.
> 
> In other cases, KBUILD_MODNAME is used instead.
> 
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>
> ---
>  drivers/staging/ipack/bridges/tpci200.c |   70 +++++++++++++++----------------
>  drivers/staging/ipack/bridges/tpci200.h |    2 -
>  2 files changed, 33 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/staging/ipack/bridges/tpci200.c b/drivers/staging/ipack/bridges/tpci200.c
> index b460587..c043345 100644
> --- a/drivers/staging/ipack/bridges/tpci200.c
> +++ b/drivers/staging/ipack/bridges/tpci200.c
> @@ -54,16 +54,15 @@ static struct tpci200_board *check_slot(struct ipack_device *dev)
>  	}
>  
>  	if (dev->slot >= TPCI200_NB_SLOT) {
> -		pr_info("Slot [%s %d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> -			TPCI200_SHORTNAME, dev->bus_nr, dev->slot,
> -			TPCI200_NB_SLOT-1);
> +		pr_info("Slot [%d:%d] doesn't exist! Last tpci200 slot is %d.\n",
> +			dev->bus_nr, dev->slot, TPCI200_NB_SLOT-1);

All of these should really be dev_err() calls, right?

You should have no pr_* calls at all in any driver, and probably none in
the ipack core as well, care to fix them all up?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/