linux-kernel - Re: [PATCH] Staging: android: alarm: fixed quoted string split across lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 May 2012 13:28:53 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Nasir Abed <nasirabed@...il.com>
cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, swetland@...gle.com,
	Nasir Abed <nasirabed+kernel@...il.com>
Subject: Re: [PATCH] Staging: android: alarm: fixed quoted string split across
 lines

On Sun, 20 May 2012, Nasir Abed wrote:

> diff --git a/drivers/staging/android/alarm.c b/drivers/staging/android/alarm.c
> index c68950b..4ea07bb 100644
> --- a/drivers/staging/android/alarm.c
> +++ b/drivers/staging/android/alarm.c
> @@ -302,8 +302,8 @@ int android_alarm_set_rtc(struct timespec new_time)
>  	}
>  	ret = rtc_set_time(alarm_rtc_dev, &rtc_new_rtc_time);
>  	if (ret < 0)
> -		pr_alarm(ERROR, "alarm_set_rtc: "
> -			"Failed to set RTC, time will be lost on reboot\n");
> +		pr_alarm(ERROR,
> +			 "alarm_set_rtc: Failed to set RTC, time will be lost on reboot\n");
>  err:
>  	wake_unlock(&alarm_rtc_wake_lock);
>  	mutex_unlock(&alarm_setrtc_mutex);

Looks like this would benefit from using __func__ since it already doesn't 
represent the correct function name.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/