linux-kernel - Re: [RFC][PATCH] hugetlb: fix resv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 May 2012 15:28:22 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
Cc:	cl@...ux.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	aarcange@...hat.com, kosaki.motohiro@...fujitsu.com,
	hughd@...gle.com, rientjes@...gle.com, adobriyan@...il.com,
	akpm@...ux-foundation.org
Subject: Re: [RFC][PATCH] hugetlb: fix resv_map leak in error path

On Fri, May 18, 2012 at 11:46:30AM -0700, Dave Hansen wrote:
> 
> When called for anonymous (non-shared) mappings,
> hugetlb_reserve_pages() does a resv_map_alloc().  It depends on
> code in hugetlbfs's vm_ops->close() to release that allocation.
> 
> However, in the mmap() failure path, we do a plain unmap_region()
> without the remove_vma() which actually calls vm_ops->close().
> 
> This is a decent fix.  This leak could get reintroduced if
> new code (say, after hugetlb_reserve_pages() in
> hugetlbfs_file_mmap()) decides to return an error.  But, I think
> it would have to unroll the reservation anyway.
> 
> This hasn't been extensively tested.  Pretty much compile and
> boot tested along with Christoph's test case.
> 
> Comments?
> 
> Signed-off-by: Dave Hansen <dave@...ux.vnet.ibm.com>

Acked-by: Mel Gorman <mel@....ul.ie>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/