linux-kernel - Re: [PATCH] perf record: Fixing record option data type in parse_branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 May 2012 11:47:10 -0300
From:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
Cc:	Stephane Eranian <eranian@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf record: Fixing record option data type in
 parse_branch_stack

Em Fri, May 25, 2012 at 04:02:15PM +0530, Anshuman Khandual escreveu:
> On Friday 25 May 2012 02:14 PM, Stephane Eranian wrote:
> 
> > Hi,
> > 
> > It should be something like that instead:
> > 
> > diff --git a/tools/perf/perf.h b/tools/perf/perf.h
> > index 8a9687e..c9ca7c4 100644
> > --- a/tools/perf/perf.h
> > +++ b/tools/perf/perf.h
> > @@ -228,7 +228,7 @@ struct perf_record_opts {
> >         unsigned int freq;
> >         unsigned int mmap_pages;
> >         unsigned int user_freq;
> > -       int          branch_stack;
> > +       u64          branch_stack;
> >         u64          default_interval;
> >         u64          user_interval;
> >  };
> > 
> 
> 
> 
> Agreed. I just tried to fix the problem where it was more evident because
> of the data type mismatch.

Can you send an updated patch on a message just for that?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/