lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 May 2012 09:57:55 +0900 From: "Jun'ichi Nomura" <j-nomura@...jp.nec.com> To: Kent Overstreet <koverstreet@...gle.com> CC: device-mapper development <dm-devel@...hat.com>, linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org, linux-fsdevel@...r.kernel.org, axboe@...nel.dk, yehuda@...newdream.net, mpatocka@...hat.com, vgoyal@...hat.com, bharrosh@...asas.com, tj@...nel.org, sage@...dream.net, agk@...hat.com, drbd-dev@...ts.linbit.com Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info On 05/26/12 05:25, Kent Overstreet wrote: > struct dm_rq_clone_bio_info { > struct bio *orig; > struct dm_rq_target_io *tio; > + struct bio clone; > }; ... > - pools->bs = bioset_create(pool_size, 0); > + pools->bs = bioset_create(pool_size, > + offsetof(struct dm_rq_clone_bio_info, orig)); > if (!pools->bs) > goto free_tio_pool_and_out; Did you mean offset of *clone*? "offsetof(struct dm_rq_clone_bio_info, orig)" is zero. And now _rq_bio_info_cache has no user and can be removed. Otherwise, I think it's nicer than the previous version. Thank you. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists