| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 May 2012 10:02:01 +0100 From: "Torne (Richard Coles)" <torne@...gle.com> To: Ben Hutchings <ben@...adent.org.uk> Cc: cjb@...top.org, linus.walleij@...aro.org, jh80.chung@...sung.com, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V2] MMC: core: cap MMC card timeouts at 2 seconds. On 29 May 2012 03:32, Ben Hutchings <ben@...adent.org.uk> wrote: > On Mon, 2012-05-28 at 18:31 +0100, Torne (Richard Coles) wrote: >> From: "Torne (Richard Coles)" <torne@...gle.com> >> >> MMC CSD info can specify very large, ridiculous timeouts, big enough to >> overflow timeout_ns on 32-bit machines. This can result in the card >> timing out on every operation because the wrapped timeout value is far >> too small. >> >> Fix the overflow by capping the result at 2 seconds. Cards specifying >> longer timeouts are almost certainly insane, and host controllers >> generally cannot support timeouts that long in any case. >> >> 2 seconds should be plenty of time for any card to actually function; >> the timeout calculation code is already using 1 second as a "worst case" >> timeout for cards running in SPI mode. > > Needs a 'Signed-off-by'. Oops, sorry. I'm still getting used to the patch workflow. Will resend. -- Torne (Richard Coles) torne@...gle.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists