linux-kernel - Re: [PATCH] drivers/leds/leds-lp5521.c: actually check return value of lp5521

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 May 2012 17:25:04 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Reinhard Tartler <siretart@...ware.de>
Cc:	Richard Purdie <rpurdie@...ys.net>, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH] drivers/leds/leds-lp5521.c: actually check return value
 of lp5521_read

Sorry, Reinhard, I just found this issue was fixed by Dan Carpenter in
mainline now, (commit 5bc9ad774c063f6b41965e7314f2c26aa5e465a0)

So I have to drop this.

-Bryan

On Tue, May 22, 2012 at 11:27 AM, Bryan Wu <bryan.wu@...onical.com> wrote:
> On Mon, May 21, 2012 at 11:35 PM, Reinhard Tartler <siretart@...ware.de> wrote:
>> This detects device failures properly. Fixes compiler warning:
>> drivers/leds/leds-lp5521.c:741: warning: 'buf' may be used uninitialized in this function
>>
>> Signed-off-by: Reinhard Tartler <siretart@...ware.de>
>> ---
>>  drivers/leds/leds-lp5521.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> This problem was found by tools developed by the VAMOS project:
>> http://www4.cs.fau.de/Research/VAMOS/
>>
>> diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
>> index 410a723..943c69d 100644
>> --- a/drivers/leds/leds-lp5521.c
>> +++ b/drivers/leds/leds-lp5521.c
>> @@ -785,7 +785,7 @@ static int __devinit lp5521_probe(struct i2c_client *client,
>>         * LP5521_REG_ENABLE register will not have any effect - strange!
>>         */
>>        ret = lp5521_read(client, LP5521_REG_R_CURRENT, &buf);
>> -       if (buf != LP5521_REG_R_CURR_DEFAULT) {
>> +       if (ret == -EIO || buf != LP5521_REG_R_CURR_DEFAULT) {
>
> Looks fine to me.
> Acked-by: Bryan Wu <bryan.wu@...onical.com>
>
> And applied to fixes-for-3.5 branch of linux-leds.git
>
> -Bryan



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/