| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 May 2012 18:26:45 +0200 From: Andi Kleen <andi@...stfloor.org> To: Johannes Goetzfried <Johannes.Goetzfried@...ormatik.stud.uni-erlangen.de> Cc: Andi Kleen <andi@...stfloor.org>, Herbert Xu <herbert@...dor.hengli.com.au>, linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, Tilo Müller <Tilo.Mueller@...ormatik.uni-erlangen.de> Subject: Re: [PATCH] crypto: serpent - add x86_64/avx assembler implementation On Wed, May 30, 2012 at 01:36:51PM +0200, Johannes Goetzfried wrote: > On Tue, May 29, 2012 at 07:27:43PM -0700, Andi Kleen wrote: > > Also drivers should never print anything when they cannot find hardware. > > Remove that printk. > > I tried to be consistent with the existing ciphers in arch/x86/crypto. > In serpent_sse2_glue.c and sha1_ssse3_glue.c it is done exactly that way, so if > it will be decided to remove the printk in this patch it probably should also > be removed in the other modules. They are wrong and need to be fixed. Drivers can be loaded for all kinds of reasons, but they are not supposed to spam your kernel log when they do nothing. In fact I fixed all the existing ones with the cpuid changes, unfortunately somehow snuck in wrong code :-( -Andi -- ak@...ux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists