linux-kernel - checkpatch: False positive on wrong indentation within block.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 31 May 2012 16:24:52 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	linux-kernel@...r.kernel.org
Cc:	apw@...onical.com
Subject: checkpatch: False positive on wrong indentation within block.

Checkpatch does not warns about the wrong indentation within a block.
When checkpatch is run on following patch, it does not complain about
the wrong indentation of if block.

[...]
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index fd019d7..a8d78f3 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -382,7 +382,12 @@ void __cpuinit set_cpu_sibling_map(int cpu)
 		if ((i == cpu) || (has_mc && match_llc(c, o)))
 			link_mask(llc_shared, cpu, i);

-		if ((i == cpu) || (has_mc && match_mc(c, o))) {
+	}
+
+	for_each_cpu(i, cpu_sibling_setup_mask) {
+		o = &cpu_data(i);
+
+	if ((i == cpu) || (has_mc && match_mc(c, o))) {
 			link_mask(core, cpu, i);

 			/*

$ ./scripts/checkpatch.pl Fix-booted_cores-reporting.patch
total: 0 errors, 0 warnings, 13 lines checked

Fix-booted_cores-reporting.patch has no obvious style problems and is ready for submission.

Thanks,
Kamalesh.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/