linux-kernel - Re: [tip:sched/core] sched/numa: Rewrite the CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jun 2012 15:16:17 +0800
From:	Alex Shi <lkml.alex@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Tony Luck <tony.luck@...el.com>, mingo@...nel.org,
	torvalds@...ux-foundation.org, cmetcalf@...era.com,
	sivanich@....com, akpm@...ux-foundation.org, ralf@...ux-mips.org,
	greg.pearson@...com, ink@...assic.park.msu.ru, tglx@...utronix.de,
	rth@...ddle.net, kamezawa.hiroyu@...fujitsu.com, paulus@...ba.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, anton@...ba.org,
	lethal@...ux-sh.org, davem@...emloft.net, benh@...nel.crashing.org,
	dhowells@...hat.com, mattst88@...il.com, fenghua.yu@...el.com,
	Alex Shi <alex.shi@...el.com>
Subject: Re: [tip:sched/core] sched/numa: Rewrite the CONFIG_NUMA sched domain support

LKP performance set 'mem=2g' for some benchmarks, that cmdline hit
kernel panic on __alloc_pages_mask on 3.5-rc1. and this patch can fix
it.
Thanks!

reported-tested-by alex.shi@...el.com


On Fri, May 25, 2012 at 3:31 PM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
> On Thu, 2012-05-24 at 14:23 -0700, Tony Luck wrote:
>> Changing both the kzalloc_node() calls in sched_init_numa()
>> into plain kzalloc() calls seems to fix things. So it looks like we are trying
>> to allocate on a node before the node has been fully set up.
>
> Right,.. and its not too important either, so lets just use regular
> allocations.
>
> That said, I can only find the 1 alloc_node() in sched_init_numa()
>
>
> ---
> Subject: sched: Don't try allocating memory from offline nodes
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Fri May 25 09:26:43 CEST 2012
>
> Allocators don't appreciate it when you try and allocate memory from
> offline nodes.
>
> Reported-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
>  kernel/sched/core.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6/kernel/sched/core.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched/core.c
> +++ linux-2.6/kernel/sched/core.c
> @@ -6449,7 +6449,7 @@ static void sched_init_numa(void)
>                        return;
>
>                for (j = 0; j < nr_node_ids; j++) {
> -                       struct cpumask *mask = kzalloc_node(cpumask_size(), GFP_KERNEL, j);
> +                       struct cpumask *mask = kzalloc(cpumask_size(), GFP_KERNEL);
>                        if (!mask)
>                                return;
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/