linux-kernel - Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 10:07:07 +0800
From:	Shaohua Li <shli@...nel.org>
To:	Tao.Guo@....com
Cc:	glorioustao@...il.com, linux-kernel@...r.kernel.org, neilb@...e.de,
	axboe@...nel.dk, stable@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] block: Move general unplug callback function from
 md/raid to blk-core

2012/6/5  <Tao.Guo@....com>:
> If you ever tried to implement unplug function in umem, you would find the code was almost identical as in dm/raid driver.
> For other components which also need such unplug mechanism, it will much more convenient to have such facilities.
It's just several lines of code and your usage actually doesn't need
the counter.
It's unclear to me your usage requires to move the callback to list head.

> PS: What's your specific concern about blk_plug_cb handles each request_queue?
the blk_plug_cb stores request_queue, which is incorrect to me. Why can't
one plug cb unplug two or more request_queues?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/