lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Jun 2012 09:05:30 +0800 From: Ming Lei <tom.leiming@...il.com> To: Stefani Seibold <stefani@...bold.net> Cc: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org, oneukum@...e.de, alan@...rguk.ukuu.org.uk, linux-usb@...r.kernel.org Subject: Re: [PATCH] fix usb skeleton driver On Wed, Jun 6, 2012 at 11:05 PM, Stefani Seibold <stefani@...bold.net> wrote: >> >> This one is not needed since we have minor_rwsem(drivers/usb/core/file.c) >> to avoid the race. >> > > The mutex is not for the minor handling, it is for the disconnect(). As usb_deregister_dev is called by disconnect, and usb_deregister_dev will acquire minor_rwsem, so there is no race between open and disconnect. When skel_open is being called, the minor_rwsem has been held already, so disconnect() will staying on acquiring minor_rwsem. So sync_mutex is not necessary at all. > mentioned in the previous posting, there is a race betwenn open() and > connect(). > > Oliver told me that a interface pointer can be already used by an other > driver when the disconnect() was called. If you mean dev->interface, that is protected by io_mutex already. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists