linux-kernel - Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Jun 2012 10:57:47 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when
 enabling as output

On Thu, Jun 7, 2012 at 11:53 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:

>> Could you elaborate on the problem ans symptoms, just for a nice
>> commit log?
>
> I'm not really sure what more there is to say...

But you do ;-)

> previously we were
> ignoring the value that's set as part of setting output mode so if
> someone wanted to set a value different to the one the chip happened to
> have that wouldn't happen.  Ignoring the vaue that the user is trying to
> set seems like an obvious enough bug in itself.

Throw that into the commit message and I'm in for it!
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/