linux-kernel - Re: [PATCH] trivial: treewide: remove extra semicolon added by module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 10 Jun 2012 14:39:54 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Felipe Balbi <balbi@...com>
CC:	<trivial@...nel.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] trivial: treewide: remove extra semicolon added by module_init/exit

(Not putting everybody in copy, but still replying)

Felipe,

On 06/06/2012 03:41 PM, Felipe Balbi :
> The definition of module_init() and module_exit()
> already added the final semicolon creating a situation
> where most of our drivers end up with two semicolons
> at the end of every module_init()/module_exit() call.
> 
> To fix that, we add missing semicolons to the places
> which didn't have them and remove the semicolons from
> the definition of module_init/module_exit.
> 
> Patch generated with the following sed script:
> 
> $ sed -i 's/^module_\(init\|exit\)\s*\((\w\+)\)$/module_\1\2;/g' \
> 	$(git ls-files)
> 
> Signed-off-by: Felipe Balbi <balbi@...com>
> ---
> 
> compile tested with allyesconfig, allnoconfig and allmodconfig on
> x86 only.
> 
> Unfortunately I couldn't Cc everybody on get_maintainer.pl's output
> due to recipient limits on TI's mail server.

[..]

>  drivers/net/ethernet/cadence/at91_ether.c             |    4 ++--

[..]


> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index 7788419..b107e7f 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -1290,8 +1290,8 @@ static void __exit at91ether_exit(void)
>  	platform_driver_unregister(&at91ether_driver);
>  }
>  
> -module_init(at91ether_init)
> -module_exit(at91ether_exit)
> +module_init(at91ether_init);
> +module_exit(at91ether_exit);
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("AT91RM9200 EMAC Ethernet driver");

For this Atmel network driver, you can add my:

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Best regards,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/