linux-kernel - Re: [PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jun 2012 12:48:56 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-driver@...gic.com,
	Andrew Vasquez <andrew.vasquez@...gic.com>, trivial@...nel.org
Subject: Re: [PATCH] [SCSI] qla2xxx: Get rid of unneeded includes of version.h

Hi Jesper,

I have already submitted a similar patch for this:

http://www.spinics.net/lists/linux-scsi/msg59815.html



On 10 June 2012 06:29, Jesper Juhl <jj@...osbits.net> wrote:
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/scsi/qla2xxx/qla_target.c |    1 -
>  drivers/scsi/qla2xxx/qla_target.h |    2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 04f80eb..f7a49e4 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -26,7 +26,6 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> -#include <linux/version.h>
>  #include <linux/blkdev.h>
>  #include <linux/interrupt.h>
>  #include <linux/pci.h>
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index 9ec19bc..7df4df5 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -919,8 +919,6 @@ struct qla_tgt_srr_ctio {
>  #define QLA_TGT_XMIT_STATUS            2
>  #define QLA_TGT_XMIT_ALL               (QLA_TGT_XMIT_STATUS|QLA_TGT_XMIT_DATA)
>
> -#include <linux/version.h>
> -
>  extern struct qla_tgt_data qla_target;
>  /*
>  * Internal function prototypes
> --
> 1.7.10.4
>
>
> --
> Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/