linux-kernel - Re: [PATCH] trivial: treewide: remove extra semicolon added by module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 12:43:50 +0300
From:	Felipe Balbi <balbi@...com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	Felipe Balbi <balbi@...com>, trivial@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trivial: treewide: remove extra semicolon added by
 module_init/exit

Hi,

On Tue, Jun 12, 2012 at 09:56:36AM +0930, Rusty Russell wrote:
> On Mon, 11 Jun 2012 14:20:28 -0700, Stephen Hemminger <shemminger@...tta.com> wrote:
> > Given common kernel practice and the fact that only 16% of the uses of
> > module_init/exit are without semicolon and that other kernel macros don't
> > include semicolon.
> > 
> > I recommend going with the majority and common practice...
> >   1. Fix the 636 places that use module_init()/exit without semicolon to include semicolon
> >   2. Remove semicolon from module_init()/exit()
> 
> Um, yes.  He should do exactly what he did.
> 
> It's a wart, let's fix it.
> 
> Thanks,
> Rusty.
> PS. CC's chopped; somewhere in there is a bad address...

let me know if you need me to update the patch.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)