linux-kernel - Re: [PATCH 1/2] driver: add PPI support in tpm driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 13:57:32 -0500
From:	Kent Yoder <shpedoikal@...il.com>
To:	"Zhang, Xiaoyan" <xiaoyan.zhang@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tpmdd-devel@...ts.sourceforge.net" 
	<tpmdd-devel@...ts.sourceforge.net>,
	"debora@...ux.vnet.ibm.com" <debora@...ux.vnet.ibm.com>,
	"srajiv@...ux.vnet.ibm.com" <srajiv@...ux.vnet.ibm.com>,
	"m.selhorst@...rix.com" <m.selhorst@...rix.com>,
	"linux-security-module@...r.kernel.org" 
	<linux-security-module@...r.kernel.org>,
	"james.l.morris@...cle.com" <james.l.morris@...cle.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"Cihula, Joseph" <joseph.cihula@...el.com>,
	"Wei, Gang" <gang.wei@...el.com>
Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver

Hi Xiaoyan,

On Tue, May 22, 2012 at 10:34 PM, Zhang, Xiaoyan
<xiaoyan.zhang@...el.com> wrote:
> From: Xiaoyan Zhang <xiaoyan.zhang@...el.com>
>
> The Physical Presence Interface enables the OS and the BIOS to cooperate
> and provides a simple and straightforward platform user experience for
> administering the TPM without sacrificing security.
>
> Signed-off-by: Xiaoyan Zhang <xiaoyan.zhang@...el.com>
> ---
>  drivers/char/tpm/tpm.c |  462 ++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/char/tpm/tpm.h |   18 ++
>  2 files changed, 480 insertions(+), 0 deletions(-)

  This code looks clean - my only suggestion would be to add an #ifdef
CONFIG_ACPI around it so it compiles out on ppc.

Kent

-- 
IBM LTC Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/