| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Jun 2012 12:40:55 +0800 From: Yuanhan Liu <yuanhan.liu@...ux.intel.com> To: linux-kernel@...r.kernel.org Cc: wfg@...ux.intel.com, Yuanhan Liu <yuanhan.liu@...ux.intel.com>, Kay Sievers <kay@...y.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: [PATCH 2/2] printk: return -EINVAL if the message len is bigger than the buf size Just like what devkmsg_read() does, return -EINVAL if the message len is bigger than the buf size, or it will trigger a segfault error. Cc: Kay Sievers <kay@...y.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Signed-off-by: Yuanhan Liu <yuanhan.liu@...ux.intel.com> --- kernel/printk.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/kernel/printk.c b/kernel/printk.c index d2ddb83..734e2a4 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -879,7 +879,9 @@ static int syslog_print(char __user *buf, int size) syslog_seq++; raw_spin_unlock_irq(&logbuf_lock); - if (len > 0 && copy_to_user(buf, text, len)) + if (len > size) + len = -EINVAL; + else if (len > 0 && copy_to_user(buf, text, len)) len = -EFAULT; kfree(text); -- 1.7.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists