linux-kernel - RE: [PATCH v2] regulator: add new regulator driver for lp872x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2012 06:42:19 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	"axel.lin@...il.com" <axel.lin@...il.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Girdwood, Liam" <lrg@...com>
Subject: RE: [PATCH v2] regulator: add new regulator driver for lp872x

> LP872X_MAX_REGULATORS is 9.
> But for LP8720, the LP8720_NUM_REGULATORS is 6.
> So this should be:
>         for (i = 0 ; i < lp->num_regulators  ; i++)

Thanks for your opinion.
In the patch v3, max loop count will be variable in case of PMU.

static struct regulator_init_data
*lp872x_find_regulator_init_data(int idx, struct lp872x *lp)
{
	int max_regulators;

	switch (lp->chipid) {
	case LP8720:
		max_regulators = LP8720_NUM_REGULATORS;
		break;
	case LP8725:
		max_regulators = LP8725_NUM_REGULATORS;
		break;
	default:
		return NULL;
	}

	for (i = 0 ; i < max_regulators ; i++)

...

Thanks & BR
Milo -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/