linux-kernel - [PATCH] ARM: sa1100: remove lart.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Jun 2012 12:46:27 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Russell King <linux@....linux.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ARM: sa1100: remove lart.h

No file includes this header. It has never been included since at least
v2.6.12-rc2. It can safely be removed.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
0) Tested only by using various git commands on the (history of the)
tree.

1) One other (potential) cleanup that I discovered while looking at the
effects of removing this header can be found in
arch/arm/mach-sa1100/lart.c:
- outdated warning, referring to a header that (in short) got removed in
commit c36167de652f8acdf0b374c78805e662646cd327 ("ide: remove dead
<asm-arm/arch-sa1100/ide.h>");
- quite a bit of code depends on macros that seem to be never defined
anywhere (eg, LART_GREY_LCD).

So that code is in need of some cleaning up. But does anyone still care
about the LART related code? Especially that outdated warning suggests
this code has seriously bit rotted.

2) While I'm at it, I might as well add some more details on the history
of lart.h, which are not really relevant for the commit explanation (or
anything else, for that matter):
- it got added in v2.4.9-pre1 and was only included by
include/asm-arm/arch-sa1100/hardware.h;
- its sole #include got removed in a patch called "[ARM] Clean up sa1100
hardware specific headers.". That patch got merged in release v2.5.47.
So it is actually unused since v2.5.47, ie it's unused for almost ten
years!

 arch/arm/mach-sa1100/include/mach/lart.h |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
 delete mode 100644 arch/arm/mach-sa1100/include/mach/lart.h

diff --git a/arch/arm/mach-sa1100/include/mach/lart.h b/arch/arm/mach-sa1100/include/mach/lart.h
deleted file mode 100644
index 8a5482d..0000000
--- a/arch/arm/mach-sa1100/include/mach/lart.h
+++ /dev/null
@@ -1,13 +0,0 @@
-#ifndef _INCLUDE_LART_H
-#define _INCLUDE_LART_H
-
-#define LART_GPIO_ETH0			GPIO_GPIO0
-#define LART_IRQ_ETH0			IRQ_GPIO0
-
-#define LART_GPIO_IDE			GPIO_GPIO1
-#define LART_IRQ_IDE			IRQ_GPIO1
-
-#define LART_GPIO_UCB1200		GPIO_GPIO18
-#define LART_IRQ_UCB1200		IRQ_GPIO18
-
-#endif
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/