linux-kernel - Re: [PATCH] leds: [trivial]Remove unnecesary return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2012 13:24:05 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	Jiri Kosina <trivial@...nel.org>, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: [trivial]Remove unnecesary return

On Wed, Jun 20, 2012 at 2:22 AM, Devendra Naga <devendra.aaru@...il.com> wrote:
> the ret is got the status returned by the
> led_classdev_register, returning ret if the
> led_classdev_register fails and returning 0
> if the led_classdev_register success, can be done
> by doing just "return ret" at the end.
>
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>

Thanks, applied to my for-next branch.

-Bryan

> ---
>
> Tested by build with the gcc linaro (arm-linux-gnueabihf) (4.7.1).
>
>  drivers/leds/leds-s3c24xx.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index bd0a5ed..e6ee105 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -106,10 +106,9 @@ static int s3c24xx_led_probe(struct platform_device *dev)
>        if (ret < 0) {
>                dev_err(&dev->dev, "led_classdev_register failed\n");
>                kfree(led);
> -               return ret;
>        }
>
> -       return 0;
> +       return ret;
>  }
>
>  static struct platform_driver s3c24xx_led_driver = {
> --
> 1.7.9.5



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/