linux-kernel - Re: [PATCH V2 3/3] staging/rtl8192u: use for loop to assign bit shifted addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Jun 2012 12:01:32 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Justin P. Mattock" <justinmattock@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 3/3] staging/rtl8192u: use for loop to assign bit
 shifted addr

Hi Joe,

On Wed, Jun 20, 2012 at 12:49 AM, Joe Perches <joe@...ches.com> wrote:
> It's also got a bit of code duplication.
> Maybe something like:
>
>        if (priv->epromtype == EPROM_93c56) {
>                addr_len = 8;
>        else
>                addr_len = 6;
>
>        test_bit = 1 << (addr_len - 1);
>        for (i = 0; i < addr_len; i++) {
>                addr_str[i] = addr & test_bit;
>                test_bit >>= 1;
>        }
>
Ahhh, true.

V3 sending :-)

Thanks,
Devendra.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/