linux-kernel - Re: linux-next: Tree for Jun 20 (hweight return type)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jun 2012 12:32:09 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Randy Dunlap <rdunlap@...otime.net>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: linux-next: Tree for Jun 20 (hweight return type)

2012/6/21, Stephen Rothwell <sfr@...b.auug.org.au>:
> On Wed, 20 Jun 2012 18:10:09 -0700 Randy Dunlap <rdunlap@...otime.net>
> wrote:
>>
>> Someone changes the return type of __const_hweight8() to
>> (unsigned long).  That causes printk format warnings when
>> hweight8/16() etc. is passed a constant:
>
> That would be "include/linux/bitops.h: fix warning" from the akpm tree
> (adding cc's).
This patch is made for fix warning message. but it looks affect other side.
Sorry for noise, I will look for other mehod. Once would you plz
revert this patch in linux-next and akpm tree ?
Thanks.
>
>>
>> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type
>> 'int', but argument 4 has type 'long unsigned int'
>> drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type
>> 'int', but argument 5 has type 'long unsigned int'
>> drivers/input/joystick/analog.c:416:5: warning: format '%d' expects type
>> 'int', but argument 5 has type 'long unsigned int'
>>
>>
>> Note that in
>>
>> #define hweight8(w)  (__builtin_constant_p(w) ? __const_hweight8(w)  :
>> __arch_hweight8(w))
>>
>> __arch_hweight*() still returns unsigned int while __const_hweight*()
>> returns unsigned long.  This can't be good, can it?
>
> --
> Cheers,
> Stephen Rothwell                    sfr@...b.auug.org.au
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/