lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jun 2012 23:50:45 -0500 From: Rob Landley <rob@...dley.net> To: Sami Kerola <kerolasa@...il.com>, Sami Kerola <kerolasa@....fi>, Jens Axboe <axboe@...nel.dk>, Bernhard Voelker <mail@...nhard-voelker.de>, Zheng Liu <wenqing.lz@...bao.com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, util-linux@...r.kernel.org Subject: Re: [PATCH] docs: block: update ioprio.txt On 06/19/2012 05:27 AM, Zheng Liu wrote: > Hi Sami, > > [You forgot to CC'd other developers and mailing list] > > On Tue, Jun 19, 2012 at 10:54:41AM +0200, Sami Kerola wrote: >> Hi Zheng, >> >> Wouldn't a patch such as below be better? > > Looks good to me. But, IMHO, if reader cannot access Internet, my patch > maybe is better for them. The original writer is not me. So I don't > understand the original idea that puts ionice source code in here. I > think that Jens can do the final decision. > > Hi Jens, > > What's your opintion about Sami's and my patch? I note that it's nice to have a reference implementation for nontrivial things. Also, util-linux isn't the end-all and be-all of linux userspace: busybox has an ionice, and I plan to add an ionice implementation to toybox as well. So fixing reference code is good. That said, this isn't a "fix", this is a rewrite adding all sorts of unnecessary complexity (internationalization? strtos32_or_error() instead of strtol()?) that makes it much _less_ effective as reference code. Rob -- GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code. Either it's "mere aggregation", or a license violation. Pick one. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists