lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Jun 2012 12:29:22 +0200 (CEST) From: Thomas Gleixner <tglx@...utronix.de> To: Rusty Russell <rusty@...tcorp.com.au> cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, "Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Tejun Heo <tj@...nel.org> Subject: Re: [RFC patch 5/5] infiniband: ehca: Use hotplug thread infrastructure On Mon, 18 Jun 2012, Thomas Gleixner wrote: > > Your infrastructure is a really weird mix. On the one hand, it's a set > > of callbacks: setup, cleanup, park, unpark. Cool. > > > > On the other hand, instead of a 'run' callback, you've got a thread_fn, > > which has to loop and call smpboot_thread_check_parking(). > > > > If you just had the thread_fn, it'd be trivial to follow program flow. > > If you just had the callbacks, it'd still be pretty easy, though it > > seems like a little too much help. I reread your reply with less sleep depriviation and now I understood your suggestion for using a run callback :) Yep, that makes sense as it moves the loop into the generic code. Will have a go on that. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists