linux-kernel - Re: [PATCH] staging: vt6656: Correct a few assignments to be compares in iwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 Jun 2012 15:08:53 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Marcos Paulo de Souza <marcos.mage@...il.com>,
	Forest Bond <forest@...ttletooquiet.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Correct a few assignments to be
 compares in iwctl_siwencodeext()

On Fri, Jun 22, 2012 at 02:28:12AM +0200, Jesper Juhl wrote:
> The result of "foo = bar" is true, so in statements such as
>   ...
>   if((pDevice->bwextstep0 = TRUE)&&(param->u.wpa_key.key_index ==1))
>   ...
> an assignment  is most likely not what was intended - a comparison was. As in:
>   ...
>   if ((pDevice->bwextstep0 == TRUE) && (param->u.wpa_key.key_index == 1))
>   ...
> 
> There are a 3 such mistakes in the iwctl_siwencodeext() function.
> This patch fixes them all.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/staging/vt6656/iwctl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>   The file could also do with a serious style cleanup, but that's a 
>   different (set of) patches. This one just fixes the bug.
> 
> diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> index b24e531..5740438 100644
> --- a/drivers/staging/vt6656/iwctl.c
> +++ b/drivers/staging/vt6656/iwctl.c
> @@ -1708,15 +1708,15 @@ if(param->u.wpa_key.alg_name == WPA_ALG_NONE) {
>     if(param->u.wpa_key.key_index ==0) {
>       pDevice->bwextstep0 = TRUE;
>      }
> -   if((pDevice->bwextstep0 = TRUE)&&(param->u.wpa_key.key_index ==1)) {
> +   if ((pDevice->bwextstep0 == TRUE) && (param->u.wpa_key.key_index == 1)) {

Good catch.

GCC would have warned about this bug except that the author tried to
program it in lisp and added stupid extra paranthesis through out.

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/