linux-kernel - Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 24 Jun 2012 11:42:30 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Joe Perches <joe@...ches.com>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Matthew Garrett <mjg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and
 tp_vdbg

On Sat, 23 Jun 2012, Joe Perches wrote:
> On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote:
> > On Sun, 17 Jun 2012, Joe Perches wrote:
> > > Use a more current logging style.
> > > 
> > > Add #define DEBUG and use pr_debug to enable dynamic debugging.
> > > Coalesce formats and align arguments.
> > > 
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > 
> > Joe, are there any extra procedures required from the user to get the debug
> > messages with this patch applied?
> 
> No.
> 
> The added #define DEBUG makes dynamic_debug emit those
> messages automatically.  Without the #define DEBUG, then

I suspected as much, but I wanted direct confirmation.  That
#define DEBUG is a relatively recent enhancement to dynamic printk, isn't
it?  Something I will have to keep in mind if I resume doing backports of
this driver for 2.6.32, 3.0 and 3.2 ?

> these tp_[v]dbg calls might not be compiled in at all.
> 
> These to_[v]dbg calls can be turned off via the normal
> dyn_debug mechanisms.
> 
> see: Documentation/dynamic-debug-howto.txt

Ok. That's good enough for me.

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/