linux-kernel - Re: [PATCH] staging: vt6656: Style cleanup of iwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 Jun 2012 09:30:41 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Forest Bond <forest@...ttletooquiet.net>,
	Marcos Paulo de Souza <marcos.mage@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Style cleanup of iwctl

On Sun, Jun 24, 2012 at 11:01:58PM +0200, Jesper Juhl wrote:
> On Sun, 24 Jun 2012, Dan Carpenter wrote:
> > Nope.  It is worth it.  Broken out patches are a million times
> > easier to review.
> > 
> Ok. I'll redo it as a series. It'll take a little while, so I may not 
> finish it tonight, but I'll do it.
> 

Thank you for redoing the new broken out version is a lot easier to
review.  For many of the patches, I just press my "filter white
space changes" button and the patch shows up as empty.  This process
takes me under five seconds.  But when it's all tangled up that
change could take minutes to untangle and verify.

> > It frustrates me that you would do things like this when you know
> > the rules.  Which part is difficult to understand?
> > 
> Nothing is difficult to understand, but breaking this into (for example) a 
> series that does:
> 	1) fix the indentation to use tabs and not spaces and proper depth
> 	2) remove space between cast and variable
> 	3) add spaces around operators (like "foo && bar" rather than "foo&&bar")
> 	4) add {} to all branches of if statement if one needs it (or remove if none need them)
> would, for many lines, result in all 4 patches changing the same lines.
> That just seemed like a little too much churn for a trivial style cleanup 
> patch.

How do I know if it's trivial or not when I can't review it
properly?  I think you are saying I should just trust you?  That's
not how it works at all.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/