linux-kernel - Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Jun 2012 16:02:30 -0700
From:	"tj@...nel.org" <tj@...nel.org>
To:	shyju pv <shyju.pv@...wei.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
	Sanil kumar <sanil.kumar@...wei.com>,
	Masanari Iida <standby24x7@...il.com>,
	Li Zefan <lizefan@...wei.com>
Subject: Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup
 cgroup]

Hello,

Does the following patch make the problem go away?

Thank you.

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 2097684..f9556cf 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3644,6 +3644,7 @@ static void cgroup_event_remove(struct work_struct *work)
 	eventfd_ctx_put(event->eventfd);
 	kfree(event);
 	dput(cgrp->dentry);
+	deactivate_super(cgrp->root->sb);
 }
 
 /*
@@ -3770,6 +3771,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
 	 * destroying subsystem state objects. Let's take reference to cgroup
 	 * directory dentry to do that.
 	 */
+	atomic_inc(&cgrp->root->sb->s_active);
 	dget(cgrp->dentry);
 
 	spin_lock(&cgrp->event_list_lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/