linux-kernel - Re: [PATCH V2 2/2] staging/comedi/drivers: free allocated priv and release resources if comedi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Jul 2012 21:36:19 +0530
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Ian Abbott <abbotti@....co.uk>,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] staging/comedi/drivers: free allocated priv and
 release resources if comedi_alloc_subdevices

Hi Dan,

On Sun, Jul 1, 2012 at 9:02 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Sun, Jul 01, 2012 at 07:12:07PM +0530, Devendra Naga wrote:
>> as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private,
>> and also the I/O regions we requested.
>>
>> free out the private data pointer of the driver, and release the I/O regions.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
>
> This breaks the build.

dev->priv should be dev->private. I was in a hurry to send the fix and
didn't build tested,
>
> Also Hartley and Ian, what's the point of alloc_private()?  It's
> just hiding stuff which we need to know about and use later on
> anyway.
>
> regards,
> dan carpenter
>
>

sorry again,

Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/