linux-kernel - Re: [PATCH 2/2] pwm: pwm-mxs: Return proper error if pwmchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Jul 2012 22:09:16 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Axel Lin <axel.lin@...il.com>
CC:	Thierry Reding <thierry.reding@...onic-design.de>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] pwm: pwm-mxs: Return proper error if
 pwmchip_remove() fails

On Sun, Jul 01, 2012 at 12:58:00PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> ---
>  drivers/pwm/pwm-mxs.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> index 269d7c2..e585264 100644
> --- a/drivers/pwm/pwm-mxs.c
> +++ b/drivers/pwm/pwm-mxs.c
> @@ -178,9 +178,7 @@ static int __devexit mxs_pwm_remove(struct platform_device *pdev)
>  {
>  	struct mxs_pwm_chip *mxs = platform_get_drvdata(pdev);
>  
> -	pwmchip_remove(&mxs->chip);
> -
> -	return 0;
> +	return pwmchip_remove(&mxs->chip);
>  }
>  
>  static struct of_device_id mxs_pwm_dt_ids[] = {
> -- 
> 1.7.9.5
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/