linux-kernel - RE: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Jul 2012 17:39:31 +0000
From:	"Matcovschi, Oleg" <oleg.matcovschi@...com>
To:	"ABRAHAM, KISHON VIJAY" <kishon@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>
Subject: RE: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or
 ID events

>From: linux-omap-owner@...r.kernel.org [linux-omap-owner@...r.kernel.org] on behalf of ABRAHAM, KISHON VIJAY
>Sent: Friday, June 22, 2012 5:10 AM
>To: gregkh@...uxfoundation.org; ABRAHAM, KISHON VIJAY; linux-omap@...r.kernel.org; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org; Balbi, Felipe
>Subject: [PATCH v3 2/5] usb: musb: twl: use mailbox API to send VBUS or ID events

>The atomic notifier from twl4030/twl6030 to notifiy VBUS and ID events,
>is replaced by a direct call to omap musb blue.

>Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>---
> drivers/usb/musb/omap2430.c   |   94 +++++++++++++++++++++++++---------------
> drivers/usb/otg/twl4030-usb.c |   46 ++++++++++----------
> drivers/usb/otg/twl6030-usb.c |   47 +++++++++-----------
> include/linux/usb/musb-omap.h |   30 +++++++++++++
> 4 files changed, 133 insertions(+), 84 deletions(-)
> create mode 100644 include/linux/usb/musb-omap.h
.....
+enum omap_musb_vbus_id_status {
+       OMAP_MUSB_UNKNOWN = 0,
+       OMAP_MUSB_ID_GROUND,
+       OMAP_MUSB_ID_FLOAT,
+       OMAP_MUSB_VBUS_VALID,
+       OMAP_MUSB_VBUS_OFF,
+};
+

Why did you choose to introduce OMAP_MUSB specific VBUS, ID events?
IMHO, it makes more sense to introduce mailbox functionality only without extra translation layer.
Same mailbox glue layer could be used for other PHY drivers, not just twl.

thanks,
 Oleg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/