linux-kernel - Re: gpio: pch/ml-ioh - leaking struct irq_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Jul 2012 09:18:21 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Jean-François Dagenais 
	<jeff.dagenais@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	linus.walleij@...ricsson.com
Cc:	open list <linux-kernel@...r.kernel.org>
Subject: Re: gpio: pch/ml-ioh - leaking struct irq_chip_generic

On Wed, Jul 4, 2012 at 4:30 AM, Jean-François Dagenais
<jeff.dagenais@...il.com> wrote:
> Am I mistaken or these two drivers are missing a "irq_remove_generic_chip()"
> then a "kfree" of the struct's memory in their xyz_remove() callbacks?
>
> Kinda like "drivers/mfd/jz4740-adc.c" does?
>

Current upstreamed GPIO drivers(showed below) use irq_alloc_generic_chip().
    drivers/gpio/gpio-ml-ioh.c
    drivers/gpio/gpio-mxc.c
    drivers/gpio/gpio-pl061.c
    drivers/gpio/gpio-pch.c
    drivers/gpio/gpio-mxs.c
    drivers/gpio/gpio-sodavil
    drivers/gpio/gpio-omap.c

However, no GPIO driver uses irq_remove_generic_chip().

I'm not familiar with these things. So I'm not sure whether
irq_remove_generic_chip is necessary or not.

Could maintainer or specialist of this tell us the information about it ?

thanks.
------
ROHM Co., Ltd.
Tomoya MORINAGA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/