lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jul 2012 01:56:41 +0000 From: "Ren, Cloud" <cjren@....qualcomm.com> To: "Huang, Xiong" <xiong@....qualcomm.com>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: qca-linux-team <qca-linux-team@...lcomm.com>, nic-devel <nic-devel@...lcomm.com> Subject: RE: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out Xiong, It looks my system time is wrong. After correct it, I will resend it. Cloud ren -----Original Message----- From: Huang, Xiong Sent: 2012年7月3日 21:04 To: Ren, Cloud; davem@...emloft.net; netdev@...r.kernel.org; linux-kernel@...r.kernel.org Cc: qca-linux-team; nic-devel Subject: RE: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out Cloud, why your patch contains : 'From: Cloud Ren <cjren@....qualcomm.com>' I don’t find it in other people's patch. Doesn't David Miller think your time is wrong ? > -----Original Message----- > From: Ren, Cloud > Sent: Tuesday, July 03, 2012 21:28 > To: davem@...emloft.net; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org > Cc: qca-linux-team; nic-devel; Ren, Cloud > Subject: [PATCH 1/1] atl1c: fix issue of transmit queue 0 timed out > > From: Cloud Ren <cjren@....qualcomm.com> > > some people report atl1c could cause system hang with following kernel > trace > info: > --------------------------------------- > WARNING: at.../net/sched/sch_generic.c:258 dev_watchdog+0x1db/0x1d0() ... > NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out ... > --------------------------------------- > This is caused by netif_stop_queue calling when cable Link is down. > So remove netif_stop_queue, because link_watch will take it over. > > Signed-off-by: xiong <xiong@....qualcomm.com> > Cc: stable <stable@...r.kernel.org> > Signed-off-by: Cloud Ren <cjren@....qualcomm.com> > --- > drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > index 85717cb..7901831 100644 > --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c > @@ -261,7 +261,6 @@ static void atl1c_check_link_status(struct > atl1c_adapter *adapter) > if ((phy_data & BMSR_LSTATUS) == 0) { > /* link down */ > netif_carrier_off(netdev); > - netif_stop_queue(netdev); > hw->hibernate = true; > if (atl1c_reset_mac(hw) != 0) > if (netif_msg_hw(adapter)) > -- > 1.7.7
Powered by blists - more mailing lists