linux-kernel - potential off by one in vdso reloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 5 Jul 2012 16:54:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	jeremy@...p.org
Cc:	linux-kernel@...r.kernel.org
Subject: potential off by one in vdso reloc_symtab()

Hi Jeremy,

I'm doing an audit for off by one errors and I had a question about
the code in reloc_symtab().

arch/x86/vdso/vdso32-setup.c
    86          for(i = 0; i < nsym; i++, sym++) {
    87                  if (sym->st_shndx == SHN_UNDEF ||
    88                      sym->st_shndx == SHN_ABS)
    89                          continue;  /* skip */
    90  
    91                  if (sym->st_shndx > SHN_LORESERVE) {
                                          ^^^^^^^^^^^^^^^

Should this be >= SHN_LORESERVE?  The other comparisons with
SHN_LORESERVE put == SHN_LORESERVE together with the >.

    92                          printk(KERN_INFO "VDSO: unexpected st_shndx %x\n",
    93                                 sym->st_shndx);
    94                          continue;
    95                  }

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/