linux-kernel - Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jul 2012 13:27:18 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Miguel Gómez <magomez@...lia.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, arnaud.patard@...-net.org,
	aaro.koskinen@....fi
Subject: Re: [PATCH 15/19] Staging: xgifb: Rework conditions in
 XGI_SetLockRegs().

On Fri, Jul 06, 2012 at 11:04:15AM +0200, Miguel Gómez wrote:
> >On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote:
> >>Rework some conditions to reduce indentation and fix style warnings.
> >>
> >>Signed-off-by: Miguel Gómez <magomez@...lia.com>
> >>---
> >>  drivers/staging/xgifb/vb_setmode.c |   29 ++++++++++++-----------------
> >>  1 file changed, 12 insertions(+), 17 deletions(-)
> >>
> >>diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> >>index a7ba99f..b439f59 100644
> >>--- a/drivers/staging/xgifb/vb_setmode.c
> >>+++ b/drivers/staging/xgifb/vb_setmode.c
> >>@@ -4039,23 +4039,18 @@ static void XGI_SetLockRegs(unsigned short ModeNo, unsigned short ModeIdIndex,
> >>  	}
> >>
> >>  	if (pVBInfo->VBInfo & SetCRT2ToHiVision) {
> >>-		if (pVBInfo->VBType & VB_SIS301LV) {
> >>-			if (pVBInfo->TVInfo & TVSetHiVision) {
> >>-				tempbx -= 10;
> >
> >We drop this -= 10 in the final.  It seems accidental.
> 
> Nope, it's done on purpose.

Ah.  You are right.  Sorry for the noise.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/