linux-kernel - Re: [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap temperature sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 7 Jul 2012 09:48:45 +0300
From:	"Valentin, Eduardo" <eduardo.valentin@...com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	j-keerthy@...com, grant.likely@...retlab.ca, b-cousson@...com,
	kbaidarov@....rtsoft.ru
Subject: Re: [PATCH 1/4] staging: OMAP4+: thermal: introduce bandgap
 temperature sensor

Hello Greg,

On Sat, Jul 7, 2012 at 2:27 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Wed, Jul 04, 2012 at 01:37:07AM +0300, Eduardo Valentin wrote:
>> In the System Control Module, OMAP supplies a voltage reference
>> and a temperature sensor feature that are gathered in the band
>> gap voltage and temperature sensor (VBGAPTS) module. The band
>> gap provides current and voltage reference for its internal
>> circuits and other analog IP blocks. The analog-to-digital
>> converter (ADC) produces an output value that is proportional
>> to the silicon temperature.
>>
>> This patch provides a platform driver which expose this feature.
>> It is moduled as a MFD child of the System Control Module core
>> MFD driver.
>>
>> This driver provides only APIs to access the device properties,
>> like temperature, thresholds and update rate.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@...com>
>> Signed-off-by: Keerthy <j-keerthy@...com>
>> ---
>>  drivers/staging/Kconfig                       |    2 +
>>  drivers/staging/Makefile                      |    1 +
>
> By not including the files these files "include" you just broke the
> build at this point in the patch series, which isn't good.
>
> Care to redo this series, so that it can build at each step of the way
> (you might do this by just adding the Kconfig and Makefile entries as
> the last patch), and then I will be glad to apply it to the tree.

Yeah. Indeed. My bad. I will resend the worked series.

>
> Oh, and yes, this implies that I have no problem taking this driver for
> the staging tree :)

Cool!

>
> thanks,
>
> greg k-h



-- 

Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/