lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Jul 2012 00:29:38 +0000 From: Haiyang Zhang <haiyangz@...rosoft.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, KY Srinivasan <kys@...rosoft.com>, "olaf@...fle.de" <olaf@...fle.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org> Subject: RE: [PATCH net,1/1] hyperv: Add support for setting MAC from within guests > -----Original Message----- > From: Ben Hutchings [mailto:bhutchings@...arflare.com] > Sent: Friday, July 06, 2012 8:19 PM > To: Haiyang Zhang > Cc: davem@...emloft.net; netdev@...r.kernel.org; KY Srinivasan; > olaf@...fle.de; linux-kernel@...r.kernel.org; devel@...uxdriverproject.org > Subject: Re: [PATCH net,1/1] hyperv: Add support for setting MAC from > within guests > > On Fri, 2012-07-06 at 14:25 -0700, Haiyang Zhang wrote: > > This adds support for setting synthetic NIC MAC address from within > > Linux guests. Before using this feature, the option "spoofing of MAC > address" > > should be enabled at the Hyper-V manager / Settings of the synthetic > > NIC. > [...] > > +int rndis_filter_set_device_mac(struct hv_device *hdev, char *mac) { > [...] > > + t = wait_for_completion_timeout(&request->wait_event, 5*HZ); > > + if (t == 0) { > > + netdev_err(ndev, "timeout before we got a set > response...\n"); > > + /* > > + * can't put_rndis_request, since we may still receive a > > + * send-completion. > > + */ > > + return -EBUSY; > > + } else { > > + set_complete = &request->response_msg.msg.set_complete; > > + if (set_complete->status != RNDIS_STATUS_SUCCESS) > > + ret = -EINVAL; > [...] > > Is there a specific error code that indicates the hypervisor is configured not > to allow MAC address changes? If so, shouldn't that be translated to return > EPERM rather than EINVAL? Will do. Thanks, - Haiyang
Powered by blists - more mailing lists