linux-kernel - [PATCH] [SCSI] suppress a warning in mpt2sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 9 Jul 2012 10:35:44 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>
Cc:	linux-scsi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Eric Moore <eric.moore@....com>,
	Nagalakshmi Nandigama <nagalakshmi.nandigama@....com>
Subject: [PATCH] [SCSI] suppress a warning in mpt2sas

Suppress this warning:

drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function '_scsih_sas_broadcast_primitive_event':
drivers/scsi/mpt2sas/mpt2sas_scsih.c:5811:40: warning: unused variable 'event_data' [-Wunused-variable]

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/scsi/mpt2sas/mpt2sas_debug.h |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

After this patch, the same code is generated.  This is relative to Linus tree.

diff --git a/drivers/scsi/mpt2sas/mpt2sas_debug.h b/drivers/scsi/mpt2sas/mpt2sas_debug.h
index 9731f8e..2a6516e 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_debug.h
+++ b/drivers/scsi/mpt2sas/mpt2sas_debug.h
@@ -79,7 +79,11 @@
 		CMD;						\
 }
 #else
-#define MPT_CHECK_LOGGING(IOC, CMD, BITS)
+#define MPT_CHECK_LOGGING(IOC, CMD, BITS)			\
+{								\
+	if (0 & IOC->logging_level & BITS)			\
+		CMD;						\
+}
 #endif /* CONFIG_SCSI_MPT2SAS_LOGGING */
 
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped