linux-kernel - Re: [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Jul 2012 12:25:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Devendra Naga <devendra.aaru@...il.com>
Cc:	Marek Belisko <marek.belisko@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] staging/ft1000: fix the spaces issue at the start of
 line

On Sat, Jul 07, 2012 at 05:35:13PM +0530, Devendra Naga wrote:
> The following warns fixed
> 
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: ERROR: code indent should use tabs where possible
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:2032: WARNING: please, no spaces at the start of a line
> 
> Signed-off-by: Devendra Naga <devendra.aaru@...il.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> index 0bd080c..c709671 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
> @@ -2029,7 +2029,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
>  	ft1000_write_reg(dev, FT1000_REG_SUP_ISR, tempword);
>  
>          // Read interrupt type
> -        inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);
> +		inttype = ft1000_read_reg (dev, FT1000_REG_SUP_ISR);

Did you just indent this one too many tabs?  Remember, a tab is 8
spaces, this should have lined up wit the line above it.  Which, for
some odd reason, is also using spaces, so why didn't that get fixed
also?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/