lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Jul 2012 10:00:27 +0930 From: Rusty Russell <rusty@...abs.org> To: Jason Vas Dias <jason.vas.dias@...il.com>, linux-kernel@...r.kernel.org Cc: Andreas Herrmann <herrmann.der.user@...glemail.com>, Matthew Garrett <mjg@...hat.com>, Len Brown <lenb@...nel.org>, Comrade DOS <suloevdmitry@...il.com> Subject: Re: [PATCH: 1/1] ACPI: make evaluation of thermal trip points before temperature or vice versa dependant on new "temp_b4_trip" module parameter to support older AMD x86_64s On Sun, 8 Jul 2012 19:50:54 +0100, Jason Vas Dias <jason.vas.dias@...il.com> wrote: > This patch adds a new acpi.thermal.temp_b4_trip = 1 settting, which > causes the temperature > to be set before evaluation of thermal trip points (the old default) ; > this mode should > be selected automatically by DMI match if the system identifies as "HP > Compaq 6715b" . > > Please consider applying a patch like that attached to fix the issue reported > in lkml thread "Re: PROBLEM: Performance drop" recently, whereby > it was found that HP 6715b laptops ( which have 2.2Ghz dual-core AMD > x86_64 k8 CPUs) > get stuck running the CPU at 800Khz and cannot switch frequency. I have verified > that this still the case with v3.4.4 tagged "stable" kernel. > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > index 7dbebea..de2b164 100644 > --- a/drivers/acpi/thermal.c > +++ b/drivers/acpi/thermal.c > @@ -96,6 +96,10 @@ static int psv; > module_param(psv, int, 0644); > MODULE_PARM_DESC(psv, "Disable or override all passive trip points."); > > +static int temp_b4_trip; > +module_param(temp_b4_trip, int, 0); > +MODULE_PARM_DESC(temp_b4_trip, "Get the temperature before > initializing trip points."); > + Hi Jason, Two points: this is a bool, why not make it one? I know, the rest of the code is old-school, but this is a new parameter. Also, why not 0644 so it can be read and set at runtime? Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists